The issue itself is real, but this PR is now a bit out of date against main. The pyproject.toml package-data entry for state/schema.sql is already present there, so the remaining value here is really the MANIFEST.in addition rather than both changes together.

The verification note also needs to be tightened. Importing init_state_db does not actually exercise the schema file read, so it does not fully prove the packaging issue is fixed. A better check would be to call init_state_db(...) against a temporary database path after a normal install and confirm that it no longer raises FileNotFoundError.

Hi @0-Shimanshu, I have added the comment noqa : E402 in test_sink.py so that module level import at the top is ignored for the 3 lines after pytest.importorskip, as it should be ignored if the app shouldn't crash when sqlalchemy isn't installed.
Is this test coverage sufficient, or would you like me to add anything else ?

The main fix looks correct now. Making the SQLAlchemy import lazy inside attach_sink() solves the plain Flask import crash, and adding the [flask] extra is the right dependency story.

Before merge, please do one small cleanup pass:

• Since adiuvare.integrations.sqlalchemy no longer imports SQLAlchemy at module scope, _sink_mode can stay imported at module scope in flask.py. It does not need to be imported inside every request.
• Please clean up the # noqa: E402 comments in tests/test_sink.py so they use the normal format.

After that, this is good to merge.

The lazy import direction is right, but I want to adjust the dependency boundary a bit before merging.

SQLAlchemy sink is not really a Flask-specific feature. Django, Flask, FastAPI, or even plain Python usage could all use the sink path. So I do not think SQLAlchemy should live under a [flask] extra.

Could you update this PR to use a dedicated sink extra instead?

Something like:

[project.optional-dependencies]
sink = [
  "sqlalchemy",
]

@0-Shimanshu , sure I will make the necessary changes and update the branch and let you know

@0-Shimanshu , I have made the necessary changes and the flask app doesn't crash anymore.

test_sink.py is skipped if sqlachemy doesn't exist.

After i run pip install .[sink],all the tests passed

Should I update the README,quickstart.md and installation.md with [sink] extra ?
I have resolved all the merge conflicts.Kindly check

The sink dependency should be documented as a dedicated extra, not under Flask.

For local development, use:
pip install ".[sink]"

That works because . means the current Python project, and pip reads the package name from pyproject.toml.
For GitHub install, document it as:
pip install "adiuvare[sink] @ git+https://github.com/0-Shimanshu/ADIUVARE.git"

And later, once we publish to PyPI, users can use:
pip install "adiuvare[sink]"

Please update README / quickstart / installation docs with this wording.
Also do one small formatting cleanup before merge:
remove the extra trailing spaces / blank lines in flask.py, sqlalchemy.py, and test_flask.py.

Sure, I'll update it

@0x070907 update
??

Hi @0-Shimanshu, apologies for the delayed response - My exams are going on.

I've now addressed all the feedback:

• Removed trailing spaces in tests/test_flask.py.
• Updated README.md, docs/installation.md, docs/quickstart.md, and docs/integrations/sqlalchemy.md to document the [sink] extra.

Should I update django.md as well?

Should I update django.md as well?

like what can u first tell me the changes.

Should I update django.md as well?

like what can u first tell me the changes.

I will add a note about the [sink] extra to docs/integrations/django.md so Django users know how to install SQLAlchemy if they want to use attach_sink() alongside Django

Should I update django.md as well?

like what can u first tell me the changes.

I will add a note about the [sink] extra to docs/integrations/django.md so Django users know how to install SQLAlchemy if they want to use attach_sink() alongside Django

i think that would be good go ahead

Should I update django.md as well?

like what can u first tell me the changes.

I will add a note about the [sink] extra to docs/integrations/django.md so Django users know how to install SQLAlchemy if they want to use attach_sink() alongside Django

i think that would be good go ahead

Its done,please check

@0x070907 dont force push it break stuff and u pushed i project.toml unecesseary file

okay,I wont force push again.But pyproject.toml is necessary because sink extra is added

okay,I wont force push again.But pyproject.toml is necessary because sink extra is added

oo ya right

@0-Shimanshu I accidentally got a merge commit on this branch,and in order to remove the commit without affecting any files or the commit history,I had to force push and I confirm that this hasn't affected any file or the main branch